Skip to content

fix: enforce evidence capability at review completion - #23

Closed
Ldsystem wants to merge 9 commits into
mainfrom
cursor/evidence-capability-review-gate-4f4b
Closed

fix: enforce evidence capability at review completion#23
Ldsystem wants to merge 9 commits into
mainfrom
cursor/evidence-capability-review-gate-4f4b

Conversation

@Ldsystem

@Ldsystem Ldsystem commented Aug 30, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Owner

Summary

  • Continue WOR-63 / PR #22 by putting the accepted pre-closure oracle-capability check on orch-review-completion, not only on the review skill.
  • Require every mapped invariant to have capable, current, correctly bounded harness-observed evidence under its allocated INV/VAL identities before archive or completion.
  • Route first-owner repair: task for failed/stale/unexecuted implementation evidence; plan for missing/wrong-boundary/incapable allocation; specification for contradictory authority.
  • Keep WOR-59 G9 / RuntimeVerificationClassificationV1 unchanged as the post-execution classifier.
  • Forbid inferring an empty map from WOR-61 none_relevant, and forbid a universal browser/E2E/runtime gate.

Why

The accepted specification places the capability gate on both orch-create-implementation-plan compilation and orch-review-plan / orch-review-completion before closure. PR #22 compiled the map and updated the review skill, but the must-enforcement review-completion rule could still close without checking oracle capability.

Validation

  • 282 focused orchestration workflow, execution-context, skill-boundary, and rule tests pass at 98eb76ebbd021f6b11cd3c41af6b0e1c184ea70f
  • New correspondence test: test_review_enforces_evidence_capability_before_closure
  • G9 regression: test_runtime_verification_classification_contract_routes_the_first_broken_artifact
  • Incapable routing remains plan; incapable -> task is still rejected
  • orchestration doctor: ok

Linear: WOR-63

Linear Issue: WOR-63

Open in Web Open in Cursor 

Ldsystem and others added 9 commits August 30, 2026 16:19
@Ldsystem
feat(orchestration): compile evidence capability maps
63558d3
@Ldsystem
fix(orchestration): preserve capability evidence IDs
30e3497
@Ldsystem
fix(orchestration): tighten evidence capability authority
a3a5641
@Ldsystem
fix(orchestration): initialize evidence closure state
6b82703
@Ldsystem
feat(orchestration): enforce evidence closure integrity
d570d48
@Ldsystem
fix(orchestration): require observed closure evidence
3108663
@Ldsystem
fix(orchestration): require produced observation batch
d03c16a
@Ldsystem
fix(orchestration): route incapable evidence to planning
7732c63
@cursoragent @Ldsystem
fix(orchestration): enforce evidence capability at review completion
98eb76e 
Require orch-review-completion and orch-review-plan to block closure
unless each mapped invariant has capable current harness-observed
evidence, while keeping WOR-59 G9 as the separate post-execution
classifier.

Co-authored-by: Ldsystem <Ldsystem@users.noreply.github.com>
@Ldsystem
Ldsystem marked this pull request as ready for review August 30, 2026 09:10
@Ldsystem

Ldsystem commented Aug 30, 2026

Copy link
Copy Markdown
Owner Author

Integrated this exact review-completion repair into the canonical WOR-63 PR #22 as commit 4697f4b. Closing the duplicate PR so review and CI converge on one issue-scoped branch; no change was discarded.

@Ldsystem Ldsystem closed this Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ldsystem @cursoragent